Skip to content

Remove omitted comment #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

Remove omitted comment #3572

merged 2 commits into from
Jul 2, 2025
+0 −2

Conversation

tataruty
Copy link
Contributor

@tataruty tataruty commented Jul 1, 2025 •
edited
Loading

Proposed changes

There is forgotten comment about ToDo that needed to be removed during #3528 fix

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

NONE

@tataruty tataruty requested a review from a team as a code owner July 1, 2025 09:00
@github-actions github-actions bot added chore Pull requests for routine tasks helm-chart Relates to helm chart labels Jul 1, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (573828e) to head (fb037d4).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3572   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         127      127           
  Lines       15226    15226           
  Branches       62       62           
=======================================
  Hits        13231    13231           
  Misses       1844     1844           
  Partials      151      151

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sjberman
sjberman reviewed Jul 1, 2025
View reviewed changes
@tataruty tataruty force-pushed the chore/remove_omitted_comment branch from 2b46f6a to a6fcf03 Compare July 1, 2025 15:23
@tataruty tataruty merged commit 58ab6e2 into main Jul 2, 2025
50 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 2, 2025
@tataruty tataruty deleted the chore/remove_omitted_comment branch July 2, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@salonichf5 salonichf5 salonichf5 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks helm-chart Relates to helm chart
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add nginxGateway.name in helm chart
4 participants
@tataruty @sjberman @ciarams87 @salonichf5